Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tests with 1D profile in PlLinesToWaternetConverterTests extended to 2D profile.

Related to Issue [MWDAM-2377]

    • -111
    • +66
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Reformat and Cleanup Deltares to update the copyright to 2025

Related to Issue [MWDAM-2038]

    • -467
    • +462
    ./PlLinesToWaternetConverterTests.cs
  1. … 396 more files in changeset.
Rename CalcPoints to Points and calcPoints to points.

Related to Issue [MWDAM-2768]

    • -149
    • +149
    ./PlLinesToWaternetConverterTests.cs
  1. … 44 more files in changeset.
Commit of the two now fixed tests.

Related to Issue [MWDAM-2764]

    • -24
    • +2
    ./PlLinesToWaternetConverterTests.cs
Commit of all tests adapted to removal of geometry point from loop/geometrypointstring.

Related to Issue [MWDAM-2764]

    • -187
    • +199
    ./PlLinesToWaternetConverterTests.cs
  1. … 28 more files in changeset.
Waternet line associated to an empty PL line (no points) is not created

Related to Issue [MWDAM-2733]

    • -22
    • +1
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
In-between aquifers situated at the left side of DikeToeAtPolder are not taken into account.

Unit tets added.

Related to Issue [MWDAM-2720]

    • -70
    • +141
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Determination of the boundaries of the in-between aquifers improved to deal with in-between aquifers cutting the not vertical geometry limit.

Unit test added.

Related to Issue [MWDAM-2716]

    • -1
    • +16
    ./PlLinesToWaternetConverterTests.cs
  1. … 5 more files in changeset.
Convert soilProfile1D to soilProfile2D for Standard and SemiTimeDependent in CreateWaternetLineForPhreaticLine.

Related to Issue [MWDAM-2623]

    • -15
    • +22
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Validations of the soil profile performed in class PlLinesCreator.cs and PlLinesToWaternetConverter.cs are moved to a new class SoilProfileValidator and called only by the PlLinesCreator.

Related to Issue [MWDAM-2164]

    • -296
    • +4
    ./PlLinesToWaternetConverterTests.cs
  1. … 14 more files in changeset.
Reference line of the waternet containing upwards vertical part is corrected (by shifting the highest point by 1cm) in order to be correctly displayed in D-Stability

Related to Issue [MWDAM-2517]

    • -0
    • +34
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
The determination of 2D aquifer layers in PlLinesToWaternetConverter is extracted to a new class SoilProfile2DHelper in order to be used by the waternet creator validator

Related to Issue [MWDAM-2525]

    • -0
    • +1198
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Code improved after review

Related to Issue [MWDAM-2410]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Unit test improved after review

Related to Issue [MWDAM-2404]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Determination of the top and bottom boundary of cluster of aquifers is improved when a not continuous aquifer is connected to a continuous aquifer

Unit tests added to highlight the problem.

Related to Issue [MWDAM-2410]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 4 more files in changeset.
Unused variables removed

Related to Issue [MWDAM-2369]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Unit tests added to highlight the problem

Related to Issue [MWDAM-2404]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Waternet is created based on SoilProfile1D when available

Related to Issue [MWDAM-2369]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 4 more files in changeset.
Tolerance used in Waternet line creator corrected.

Related to Issue [MWDAM-2380]

    • too large
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Fifth commit of the combining code for SurfaceLine and SoilProfile2D. Still work to be done and to be tested.

Related to Issue [MWDAM-2258]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test for 1D soil profile splits into 2 cases

Related to Issue [MWDAM-2252]

    • too large
    ./PlLinesToWaternetConverterTests.cs
Adapted to review: Unit test split into 2 cases

Related to Issue [MWDAM-2252]

    • -140
    • +174
    ./PlLinesToWaternetConverterTests.cs
Code improved

Related to Issue [MWDAM-2271]

Unit tests added to highlights the problems

Related to Issue [MWDAM-2271]

    • -0
    • +183
    ./PlLinesToWaternetConverterTests.cs
  1. … 3 more files in changeset.
Sonar cloud issues solved

Related to Issue [MWDAM-2251]

Case where phreatic line passes through all layers of 2D profile is better handled.

Also added that the waternet line for PL1 can't be situated in the bottom aquifer.

Related to Issue [MWDAM-2252]

    • -62
    • +39
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Waternet line for in-between aquifer changed into 2 lines instead of a close boundary to be correctly displayed in STIX file.

Related to Issue [MWDAM-2242]

    • -54
    • +67
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Adapted to review: exception is raised when no bottom aquifer present

Related to Issue [MWDAM-2225]

    • -32
    • +22
    ./PlLinesToWaternetConverterTests.cs
  1. … 1 more file in changeset.
Obsolete code removed and unit tests updated

Related to Issue [MWDAM-2246]

    • -1
    • +13
    ./PlLinesToWaternetConverterTests.cs
  1. … 2 more files in changeset.
Assert.Multiple called when possible

Related to Issue [MWDAM-2225]

    • -35
    • +53
    ./PlLinesToWaternetConverterTests.cs