Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed failing tests.

Related to Issue [MWDAM-1627]

    • -2
    • +2
    ./Dam/Tests/CalculationParametersAssemblerTest.cs
Fixed tests that failed due to improved message.

Related to Issue [MWDAM-1677]

    • -3
    • +4
    ./Dam/Tests/CalculationParametersAssemblerTest.cs
Modified conversion for a SoilProfile2D:

- Always set the layers to HydroStatic WaterPressureInterPolationModel when importing

Related to Issue [MWDAM-1686]

Modified conversion for a SoilProfile2D:

- Fixed conversion for the WaterpressureInterpolationModel for a SoilLayer2D

Related to Issue [MWDAM-1686]

Modified conversion for a SoilProfile2D:

- Fixed failing unit tests: added aquifer dictionary to the SoilList to prevent KeyNotFoundExceptions

Related to Issue [MWDAM-1686]

Modified conversion for a SoilProfile2D:

- Added step to transfer layer properties in the SoilProfile2DImporter

Related to Issue [MWDAM-1686]

Modified conversion for a SoilProfile2D:

- Explicitly set to a SoilProfile2D in case it is a sti file. Sti files are now read by in the FillDamUiFromXmlInput and should be passed as a SoilProfile2D instead

Related to Issue [MWDAM-1686]

Improved error message for obsolete parameters in parameters xml.

Related to Issue [MWDAM-1677]

Improved error message for obsolete parameters in parameters xml.

Related to Issue [MWDAM-1677]

Corrected reading for v20, stumbled on this when trying to reproduce the error in v20 before it was decided to solve it for v19.

Related to Issue [MWDAM-1579]

Incorporated comments reviewer:

- Restored and commented original test categories

Related to Issue [MWDAM-1630]

Incorporated comments reviewer:

- Removed dead code

- Fixed string values

Related to Issue [MWDAM-1630]

    • -1
    • +0
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
Incorporated comments reviewer:

- Made FailureMechanismSystemType.StabilityOutside invisible

- Improved source code by cleaning up the nested switch

Related to Issue [MWDAM-1630]

    • -11
    • +11
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
    • -0
    • +42
    ./Dam/Tests/DamFailureMechanismeCalculationSpecificationTest.cs
Incorporated comments reviewer:

- Ensured that the soil profile names are distinct for 1D profiles

Related to Issue [MWDAM-1380]

Fixed SonarQube issues

Related to Issue [MWDAM-1374]

Set failing tests to "WorkInProgress" category:

- Tests currently fail due to the functional requirement that only outdated projects with UpliftVan model settings are supported and loaded into the application.

Related to Issue [MWDAM-1630]

Incorporated comments reviewer:

- Added test to verify that the 1D and 2D profiles are serialized correctly

Related to Issue [MWDAM-1380]

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Removed duplicate entry

Related to Issue [MWDAM-1630]

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Disabled options also in the ConfigurationManager, as this gives problems when loading older projects

Related to Issue [MWDAM-1630]

Added check to validate whether the outdate file is supported:

- Only files that contain UpliftVan settings are currently supported --> if old files are not made with these settings, do not load further and generate an error message.

Related to Issue [MWDAM-1630]

Fixed failing tests:

- Removed all mentions to the Wti kernel

Related to Issue [MWDAM-1630]

Removed StabilityKernelType:

- Removed combobox binding and replaced it with a static label indicating which kernel is used

- Removed obsolete Translations.xml entries

Related to Issue [MWDAM-1630]

    • -0
    • +3
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
    • -20
    • +2
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.Designer.cs
Removed StabilityKernelType:

- Removed obsolete enum

Related to Issue [MWDAM-1630]

Removed StabilityKernelType:

- Removed from the CsvExportData

Related to Issue [MWDAM-1630]

Removed StabilityKernelType:

- Removed from the FailureMechanismCalculationSpecification and its affected callers.

Related to Issue [MWDAM-1630]

    • -8
    • +5
    ./Dam/Tests/DamCalculationBenchmarkTest.cs
    • -10
    • +0
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
Removed StabilityKernelType:

- Removed from the DamProjectCalculationSpecification and its affected callers.

Related to Issue [MWDAM-1630]

    • -2
    • +0
    ./Dam/Forms/StabilityKernelTypeSpecificationsControl.cs
Removed StabilityKernelType:

- Removed from the ConfigurationManager and its affected callers.

Related to Issue [MWDAM-1630]

    • -4
    • +4
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
Removed StabilityKernelType:

- Removed from the FillXmlInputFromDamUi

Related to Issue [MWDAM-1630]

Disabled model selection when StabilityOutside or StabilityInside failure mechanism is active:

- Set UpLiftVan as default value when a new project is made

- Added tests to verify behaviour

Related to Issue [MWDAM-1630]

    • -0
    • +55
    ./Dam/Tests/MStabParametersTest.cs
    • -0
    • +110
    ./Dam/Tests/DamFailureMechanismeCalculationSpecificationTest.cs
    • -10
    • +14
    ./DamClientsLibrary/Deltares.Dam.Data/DamFailureMechanismeCalculationSpecification.cs
Incorporated comments reviewer:

- Reverted SoilGeometry2DName to simply the profile name (without extension)

Related to Issue [MWDAM-1380]