DAM / DamEngine / trunk

src

Checkout Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit: 17 Dec
Commits this week: 0
Total Lines of Code (LoC): 147,819
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Feb 2020
9:03 am

tang_ds

Moved TestHelper class to a dedicated testhelper folder:

- Class has nothing to do with DamMacroStability and is used by other kernelwrappers. Class should therefore be kept in a separate solution folder

Related to Issue [MWDAM-1629]

Options
    • -0
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocTests.cs
    • -0
    • +261
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestHelpers/DamMacroStabilityTestHelper.cs
    • -261
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/UpliftHelperTests.cs
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityInwards/MacroStabilityInwardsKernelWrapperTests.cs
  6. ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestHelpers
  7. ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/TestHelpers
    • -2
    • +4
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
8:49 am

tang_ds

Disabled failing tests:

- MacroStabilityInwards functionality is currently severed and non-functional. Test should be re-enabled once the new kernelwrapper is in place

Related to Issue [MWDAM-1629]

Options
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
8:41 am

tang_ds

Incorporated comment reviewer:

- Removed too much during cleanup, restored the testing of design result 0 and 1

Related to Issue [MWDAM-1355]

Options
    • -3
    • +5
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Tuesday 11 Feb 2020
4:45 pm

tang_ds

Removed DamMacroStabilityHorizontalBalance:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

Options
    • -7
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/KernelWrapperHelper.cs
  2. ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityHorizontalBalance
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
  4. ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityHorizontalBalance
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -318
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityHorizontalBalance/DamMacroStabilityHorizontalBalanceKernelWrapper.cs
    • -360
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityHorizontalBalance/DamMacroStabilityHorizontalBalanceKernelWrapperTests.cs
4:42 pm

tang_ds

Disabled failing tests:

- MacroStabilityInwards functionality is currently severed and non-functional. Test should be re-enabled once the new kernelwrapper is in place

Related to Issue [MWDAM-1629]

Options
    • -0
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
4:39 pm

tang_ds

Disabled failing tests:

- MacroStabilityOutwards functionality is currently severed and non-functional. Test should be re-enabled once the new kernelwrapper is in place

Related to Issue [MWDAM-1629]

Options
    • -5
    • +1
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
4:28 pm

tang_ds

Removed DamMacroStabilityInwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

Options
  1. ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityInwards
  2. ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityInwards
    • -4
    • +1
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/KernelWrapperHelper.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
    • -660
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityInwards/DamMacroStabilityInwardsKernelWrapper.cs
    • -334
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityInwards/DamMacroStabilityInwardsKernelWrapperTests.cs
4:14 pm

tang_ds

Removed DamMacroStabilityOutwards:

- Adjusted the KernelWrapperHelper

Related to Issue [MWDAM-1629]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Calculators/Deltares.DamEngine.Calculators.csproj
    • -12
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/KernelWrapperHelper.cs
    • -1
    • +0
    ./Deltares.DamEngine.Calculators.Tests/Deltares.DamEngine.Calculators.Tests.csproj
  4. ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityOutwards
  5. ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityOutwards
    • -357
    • +0
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapper.cs
    • -433
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityOutwards/DamMacroStabilityOutwardsKernelWrapperTests.cs
3:36 pm

tang_ds

Cleanup:

- Formatting

Related to Issue [MWDAM-1355]

Options
    • -1
    • +0
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
3:36 pm

tang_ds

Fixed failing unit tests:

- Removed zone parameters from the DamProject as these are no part of the output anymore. These (additional) parameters can still be read, but are not processed further which causes a failing test due to expected serialized values.

Related to Issue [MWDAM-1355]

Options
    • -6
    • +0
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
3:34 pm

tang_ds

Added specific unit test for checking the CreateOutput logic of design results containing MacroStability results:

- Added check for the creation of the surfaceline

Related to Issue [MWDAM-1355]

Options
    • -12
    • +90
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
1:38 pm

tang_ds

Added specific unit test for checking the CreateOutput logic of design results containing MacroStability results

Related to Issue [MWDAM-1355]

Options
    • -0
    • +133
    ./Deltares.DamEngine.Interface.Tests/FillXmlOutputFromDamTests.cs
1:29 pm

tang_ds

Regenerated DamOutput.cs based on the new XSD:

- Removed obsolete code related to the zoning parameters

Related to Issue [MWDAM-1355]

Options
    • -156
    • +0
    ./Deltares.DamEngine.Io/DamOutput.cs
    • -12
    • +0
    ./Deltares.DamEngine.Interface/FillDamFromXmlOutput.cs
    • -18
    • +0
    ./Deltares.DamEngine.Interface/FillXmlOutputFromDam.cs
    • -73
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityInwardsTests.cs
Thursday 06 Feb 2020
10:29 am

John Bokma

Corrected test.

Related to Issue [MWDAM-1383]

Options
    • -2
    • +0
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
Wednesday 05 Feb 2020
7:04 pm

John Bokma

Adapted to comments some more.

Related to Issue [MWDAM-1383]

Options
    • -0
    • +4
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/MacroStabilityCommon/ConversionHelperTests.cs
    • -2
    • +5
    ./Deltares.DamEngine.Calculators/KernelWrappers/MacroStabilityCommon/MacroStabilityIo/ConversionHelper.cs
3:18 pm

John Bokma

Adapted in accordance with review comments.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +13
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -4
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -19
    • +19
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -0
    • +5
    ./Deltares.DamEngine.Data/General/Dike.cs
Tuesday 04 Feb 2020
6:43 pm

John Bokma

Fixed failing slow tests.

Related to Issue [MWDAM-1618]

Options
    • -4
    • +4
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Invoer10.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile1LocationWithAdaption.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile18.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwards.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/ErrorInDGeoStabilityCalculation.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkZoneringInwardsZone2.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/MacroStabilityTutorialDesignInputFile13.xml
5:50 pm

John Bokma

Fixed failing tests.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DesignInputFileWithRiverLevelAboveDikeTopButBelowDTH.xml
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedFailedDesignInputFile_1Location.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_WtiSellmeijerRevisedInputFile.xml
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/DeltaDijkInvoer3VNKAdaptionShoulderLength.xml
3:47 pm

Tom The

Release binaries

Related to Issue [MWDAM-1345]

Related to Issue [MWDAM-1617]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
  2. … 13 more files in changeset.
2:59 pm

John Bokma

Moved HeadPl2 within Location from WaternetOptions to DesignScenario. Also removed HeadPl3 and HeadPl4 from Location.

Started fixing failing tests.

Related to Issue [MWDAM-1618]

Options
    • -6
    • +6
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -2
    • +2
    ./Deltares.DamEngine.Interface/FillXmlInputFromDam.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapperTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighInputFile.xml
    • -1
    • +1
    ./Deltares.DamEngine.Interface/FillDamFromXmlInput.cs
    • -1
    • +6
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/Common/PlLinesHelperTests.cs
    • too large
    ./Deltares.DamEngine.IntegrationTests/TestFiles/Rechter Diezedijk_BlighDesignInputFile.xml
    • -2
    • +3
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapperTests.cs
    • -5
    • +5
    ./Deltares.DamEngine.Data/General/Sensors/SensorLocation.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamPipingSellmeijer4Forces/DamPipingSellmeijer4ForcesKernelWrapperTests.cs
    • -4
    • +28
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -2
    • +3
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
  16. … 4 more files in changeset.
2:50 pm

Tom The

Fixed unit test

Update FO

Related to Issue [MWDAM-1617]

Related to Issue [MWDAM-1345]

Related to Issue [MWDAM-1617]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
  2. … 2 more files in changeset.
1:16 pm

Tom The

Fixed failing unit test

Related to Issue [MWDAM-1617]

Options
    • -204
    • +204
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
    • -1
    • +1
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
12:11 pm

John Bokma

Moved PolderLevel within Location from WaternetOptions to DesignScenario.

Related to Issue [MWDAM-1618]

Options
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingBligh/DamPipingBlighKernelWrapper.cs
    • -42
    • +26
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
    • -0
    • +9
    ./Deltares.DamEngine.Data/Design/DesignScenario.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/KernelWrappers/Common/PlLinesHelper.cs
    • -7
    • +7
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineAdapterTest.cs
    • -2
    • +6
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorLocationTests.cs
    • too large
    ./Deltares.DamEngine.Io/DamInput.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineShoulderAdapter.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
    • -3
    • +3
    ./Deltares.DamEngine.Calculators/KernelWrappers/DamPipingSellmeijerVnk/DamPipingSellmeijerVnkKernelWrapper.cs
    • too large
    ./Deltares.DamEngine.Calculators.Tests/DikesDesign/SurfaceLineShoulderAdapterTest.cs
    • -1
    • +2
    ./Deltares.DamEngine.TestHelpers/Factories/FactoryForDamProjectData.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorCombinedSlopeAndShoulderAdaption.cs
    • -1
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/SurfaceLineHeightAdapter.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/DikesDesign/DesignCalculatorFirstSlopeAdaptionThenShoulderAdaption.cs
  16. … 15 more files in changeset.
9:26 am

Tom The

Add ignored test to be used for debugging input XM files

Related to Issue [MWDAM-1617]

Options
    • -0
    • +535
    ./Deltares.DamEngine.IntegrationTests/TestFiles/InputForDebugging.xml
    • -0
    • +4
    ./Deltares.DamEngine.IntegrationTests/Deltares.DamEngine.IntegrationTests.csproj
    • -0
    • +55
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/DebuggingTest.cs
Friday 02 Aug 2019
4:01 pm

John Bokma

Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -2
    • +2
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/PipingBlighTests.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityHorizontalBalance/DamMacroStabilityHorizontalBalanceKernelWrapperTests.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/WtiPipingSellmeijerRevisedTests.cs
    • -44
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/MacroStabilityOutwardsTests.cs
3:16 pm

John Bokma

Fixed some more failing tests by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -1
    • +1
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocTests.cs
    • -0
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/DamMacroStabilityTestHelper.cs
    • -8
    • +8
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestData/Expected1D1.xml
1:28 pm

John Bokma

Fixed failing test by adapting data.

Related to Issue [MWDAM-1345]

Options
    • -1
    • +2
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/MStabXmlDocTests.cs
    • -6
    • +6
    ./Deltares.DamEngine.Calculators.Tests/KernelWrappers/DamMacroStabilityCommon/TestData/Expected1D1.xml
11:36 am

John Bokma

Fixed problem 1 as stated by PO in issue, just throw error when water level (high/low) at riverside is below dike toe. Added tests for this.

Related to Issue [MWDAM-1345]

Options
    • too large
    ./Deltares.DamEngine.Calculators.Tests/PlLinesCreator/PlLinesCreatorTest.cs
    • -8
    • +16
    ./Deltares.DamEngine.Data/Geotechnics/SurfaceLine2Extensions.cs
    • too large
    ./Deltares.DamEngine.Calculators/PlLinesCreator/PlLinesCreator.cs
    • -2
    • +2
    ./Deltares.DamEngine.Calculators/PlLinesCreator/SensorPlLine1Creator.cs
    • -0
    • +65
    ./Deltares.DamEngine.Calculators.Tests/Sensors/SensorPLLineCreatorTest.cs
Thursday 01 Aug 2019
5:25 pm

Tom The

I improved some code (code was correct, but prevent SonarQube message and improved exception testing in the tests)

Related to Issue [MWDAM-1445]

Options
    • -2
    • +0
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs
    • -3
    • +3
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
  3. … 1 more file in changeset.
12:41 pm

John Bokma

Added code (with tests) to improve handling of "wrong" segments. To be able to test this properly, added PipingModelType.Wti2017 to supported models so we can actually define an improper test project. Adding this also helps for MWDAM-1393 and thus MWDAM-1145, Piping part.

Related to Issue [MWDAM-1445]

Options
    • -8
    • +13
    ./Deltares.DamEngine.Calculators/KernelWrappers/WtiPipingSellmeijerRevised/WtiPipingSellmeijerRevisedKernelWrapper.cs
    • -0
    • +66
    ./Deltares.DamEngine.IntegrationTests/IntegrationTests/OperationalGrebbedijkTests.cs
    • -18
    • +53
    ./Deltares.DamEngine.Calculators/DikesOperational/OperationalCalculator.cs